Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing - Show the previous form when the user cancel current editing #5121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdouchin
Copy link
Collaborator

@mdouchin mdouchin commented Dec 12, 2024

Sometimes, the user can forget that the editing form has been previously opened to create or edit a feature.
Some other tools can have been used, such as the Layers legend panel, which hides the form.

This PR displays the editing form back before showing the confirmation message, so that the user can see the previous form in its current state and make the correct decision.

Funded by AMP Métropole

@github-actions github-actions bot added this to the 3.10.0 milestone Dec 12, 2024
@mdouchin mdouchin force-pushed the editing_display_form_on_new_editing_warning_message branch from a118a48 to efb6da7 Compare December 12, 2024 09:57
@mdouchin mdouchin force-pushed the editing_display_form_on_new_editing_warning_message branch from efb6da7 to f1aac1e Compare December 12, 2024 09:58
@mdouchin
Copy link
Collaborator Author

mdouchin commented Dec 12, 2024

  • Not sure about the addition of async...
  • We could also zoom back to the previously edited geometry ?

@mdouchin
Copy link
Collaborator Author

cc @Gustry

@mdouchin mdouchin added javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Dec 12, 2024
@mdouchin mdouchin marked this pull request as ready for review December 12, 2024 11:18
@Gustry Gustry added the sponsored development This development has been funded label Dec 12, 2024
@rldhont
Copy link
Collaborator

rldhont commented Dec 12, 2024

@nboisteault can you give us your point of view ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 backport release_3_9 editing form javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants